-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates iteration 1 #1311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in favor of open
jackofdiamond5
added
commands
❌ status: awaiting-test
cli-package
igniteui-cli package
labels
Sep 4, 2024
Hristo313
added
💥 status: in-test
✅ status: verified
and removed
❌ status: awaiting-test
💥 status: in-test
labels
Sep 9, 2024
Hristo313
previously approved these changes
Sep 9, 2024
Lipata
previously approved these changes
Sep 10, 2024
dafo
reviewed
Sep 11, 2024
jackofdiamond5
dismissed stale reviews from Lipata and Hristo313
via
September 12, 2024 06:39
7b7fd67
Lipata
approved these changes
Sep 12, 2024
Hristo313
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1294
This PR updates packages of the root CLI project, as well as the CLI package sub-project.
Updating
yargs
required some changes in all of the CLI's commands, as the newest version of the package is used and the API is quite different to what we've been using so far. Additionally, strict types have been introduced everywhere possible for each individual command. Also, some new tests have been introduced for thehelp
command since we did not have full coverage for all available commands. Finally, thefs-extra
package has been removed and the code has been updated to usefs
instead,Currently there is a problem with the CLI where running a command with aliased options fails - #1312
Notes for testing:
All commands should be tested one at a time to ensure that they work as expected.
ig --help
)ig add --help
)A project should be generated with
sass
/less
styles and it should work just fine (all styles files should be copied properly) - this is due to the removal offs-extra
where it was used to copy the styles to the generated project's directory. Now custom logic handles this and it should be tested.