-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip - Update indigo theme #1391
base: master
Are you sure you want to change the base?
Conversation
make sure that the hover is working even when the chip is focused.
Everything looks good here too. Thanks @desig9stein |
@desig9stein i dont know if you fixed it yet, but i dont see the issue nº 2... Some of the opacity issues might be related to the addition of opacity on the disabled component, yes @desig9stein ? So the text color being white for some of the variant chips (info, success, warning and error) is correct according to the handoff. But the primary chip didnt follow these rules, because it looked identical to the selected chip... so i kept the same criteria for the primary chip. But this may be confusing.... The other variants are fine on disabled.... maybe i still need to fix the primary chip, to match the same behavior as the other colored variants? |
Closes IgniteUI/igniteui-theming#326