refactor: Added support for string-based property values for date based components #1470
+307
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed components This commit adds support for passing in string based date values to date-bound properties of calendar, date-time input and date picker components. The component will now try to parse the passed in value without directly throwing an exception. Unified the type declarations between date-bound component.
damyanpetev
reviewed
Nov 12, 2024
| this._value = value; | ||
| this._setFormValue(value ? value.toISOString() : null); | ||
| @property({ converter: convertToDate }) | ||
| public set value(value: Date | string | null) { |
There was a problem hiding this comment.
I know only the backing field change, but just as an example from AB:
This will error out on strict checks and it's not restricted to just the date components. Could be a separate issue for most components by the looks of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for passing in string based date values to date-bound properties of calendar, date-time input and date picker components. The component will now try to parse the passed in value without directly throwing an exception.
Unified the type declarations between date-bound component.
Closes #1467