Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

complete integration with LMS UI CDN #1

Merged
merged 3 commits into from
Aug 20, 2021
Merged

complete integration with LMS UI CDN #1

merged 3 commits into from
Aug 20, 2021

Conversation

rupeshparab
Copy link
Contributor

@rupeshparab rupeshparab commented Aug 18, 2021 •
edited
Loading

This PR does the following:

  1. Adds Custom UI handler
  2. Updates tab logic with the new UI link (/formgradernext)

UI handler logic

  1. Fetches the index.html of LMS UI based on LMS_VERSION (at time of startup)
  2. Injects base_url in index.html and returns it to requestor

Note: this PR is dependent on some WIP changes in LMS UI

jgwerner
jgwerner approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 20aa038 into main Aug 20, 2021
@jgwerner jgwerner deleted the feature/lms-ui branch August 20, 2021 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgwerner jgwerner jgwerner approved these changes

Assignees

@rupeshparab rupeshparab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupeshparab @jgwerner