Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize long and lon for longitude #51

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Recognize long and lon for longitude #51

merged 3 commits into from
Sep 1, 2023

Conversation

egrace479
Copy link
Member

Added ability to recognize long and lon for longitude, and a test for the long change.

@egrace479 egrace479 marked this pull request as draft August 31, 2023 22:05
@egrace479 egrace479 marked this pull request as ready for review August 31, 2023 22:09
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnbradley
Copy link
Contributor

johnbradley commented Sep 1, 2023

What do you think about ignoring case when looking for lat and long? The Andromeda iNaturalist code creates columns Lat and Long.

@egrace479
Copy link
Member Author

What do you think about ignoring case when looking for lat and long? The Andromeda iNaturalist code creates columns Lat and Long.

It would be simple enough to just set all column names to lowercase with str.lower before the check or str.capitalize to capitalize them (potentially better for display?).

…--change carried through all calls and tests). Updated readme to reflect increased flexibility.
@egrace479
Copy link
Member Author

What do you think about ignoring case when looking for lat and long? The Andromeda iNaturalist code creates columns Lat and Long.

It would be simple enough to just set all column names to lowercase with str.lower before the check or str.capitalize to capitalize them (potentially better for display?).

Realized the capitalization should be carried through as it's likely going to stick with greater generalization of later versions. This made for more files changed, but small changes. @johnbradley do you think that works/makes sense now?

Copy link
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/components/test_query.py Outdated Show resolved Hide resolved
Co-authored-by: Matt Thompson <[email protected]>
@egrace479 egrace479 merged commit ee5c877 into dev Sep 1, 2023
2 checks passed
@egrace479 egrace479 mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants