-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependence on Image_filename
for image selector
#62
Conversation
I also noticed a bug in the dropdown selector: if you go from specifying subspecies to selecting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one spelling fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few EOF newlines
Co-authored-by: John Bradley <[email protected]>
Add EOF newlines to CSVs Co-authored-by: Matt Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one nitpicking suggestion :-)
Co-authored-by: Hilmar Lapp <[email protected]>
Displaying sample images required both
image_filename
andfile_url
columns. This was an unnecessary complication that is removed in this PR.Also prints a more specific message when no images are displayed (indicating there are no such entries vs. there are no displayable images for those X entries). This isn't a change in options, just a change in the message itself for greater clarity.