-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples and update dependencies #34
Conversation
Add deep link example
Rename SquireCropImage to CropImage, ratio can be set from the parameter
Update ci-cd, Add BMC button
Fix ktlint issues
…olor to match with sheet bg
Migrate navigation
} | ||
|
||
// Use Android Studio menu "Code -> Generate -> toString()" to auto generate `toString()`. | ||
override fun toString(): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
var cache = mutableMapOf<String, Any>() | ||
private set | ||
|
||
inline fun <reified T> get(forKey: MemoryCacheKey): T? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
} | ||
} | ||
|
||
fun String.urlEncode(): String { | ||
return URLEncoder.encode(this, "utf-8") | ||
} | ||
|
||
fun String.urlDecode(): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
private var sharedPref: SharedPreferences? = null | ||
|
||
@PublishedApi | ||
internal fun getSharedPerf(): SharedPreferences { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
Add memory cache example with data passing
Merge pull request #36 from ImaginativeShohag/memory-cache
feat(dark-light-theme): Add auto ui theme mode
companion object { | ||
private val map = entries.associateBy(UIThemeMode::value) | ||
|
||
fun fromValue(value: Int): UIThemeMode? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
} | ||
|
||
fun getToken(): String? { | ||
return getSharedPerf().getString(PREF_TOKEN, null) | ||
fun getToken(): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
@@ -95,7 +97,11 @@ fun GeneralAppBar( | |||
toggleUIMode() | |||
}) { | |||
Icon( | |||
imageVector = if (isDarkMode) Icons.Rounded.DarkMode else Icons.Rounded.LightMode, | |||
imageVector = when(uiThemeMode) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:keyword-spacing reported by reviewdog 🐶
Missing spacing after "when"
No description provided.