Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http:// → https:// #268

Merged
merged 1 commit into from
Oct 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ If you use highdicom in your research, please cite the above article.
The developers gratefully acknowledge their support:
* The [Alliance for Digital Pathology](https://digitalpathologyalliance.org/)
* The [MGH & BWH Center for Clinical Data Science](https://www.ccds.io/)
* [Quantitative Image Informatics for Cancer Research (QIICR)](http://qiicr.org)
* [Radiomics](http://radiomics.io)
* [Quantitative Image Informatics for Cancer Research (QIICR)](https://qiicr.org/)
* [Radiomics](https://www.radiomics.io/)
* The [NCI Imaging Data Commons](https://imaging.datacommons.cancer.gov/)
4 changes: 2 additions & 2 deletions docs/coding.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ Examples of widely used medical terminologies include:
terminology. This terminology is defined within the DICOM standard itself and
is used to refer to DICOM concepts, as well as other concepts
within the radiology workflow.
- `SNOMED-CT <http://snomed.info/sct>`_. This terminology contains codes to
- `SNOMED-CT <https://www.snomed.org/>`_. This terminology contains codes to
describe medical concepts including anatomy, diseases, and procedures.
- `RadLex <http://www.radlex.org/>`_. A standardized terminology for concepts
- `RadLex <https://radlex.org/>`_. A standardized terminology for concepts
in radiology.
- `UCUM <https://ucum.org/>`_. A terminology specifically to describe units of
measurement.
Expand Down
4 changes: 2 additions & 2 deletions docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Coding style
------------

Code must comply with `PEP 8 <https://www.python.org/dev/peps/pep-0008/>`_.
The `flake8 <http://flake8.pycqa.org/en/latest/>`_ package is used to enforce compliance.
The `flake8 <https://flake8.pycqa.org/en/latest/>`_ package is used to enforce compliance.

The project uses `numpydoc <https://github.com/numpy/numpydoc/>`_ for documenting code according to `PEP 257 <https://www.python.org/dev/peps/pep-0257/>`_ docstring conventions.
Further information and examples for the NumPy style can be found at the `NumPy Github repository <https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt>`_ and the website of the `Napoleon sphinx extension <https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_numpy.html#example-numpy>`_.
Expand All @@ -46,7 +46,7 @@ Types must be specified using type hints as specified by `PEP 484 <https://www.p
Running tests
-------------

The project uses `pytest <http://doc.pytest.org/en/latest/>`_ to write and runs unit tests.
The project uses `pytest <https://doc.pytest.org/en/latest/>`_ to write and runs unit tests.
Tests should be placed in a separate ``tests`` folder within the package root folder.
Files containing actual test code should follow the pattern ``test_*.py``.

Expand Down
2 changes: 1 addition & 1 deletion docs/generalsr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ explanation my be found in:

* *DICOM Structured Reporting*. David Clunie. PixelMed Publishing, 2000.
Digital copy available
`here <http://www.dclunie.com/pixelmed/DICOMSR.book.pdf>`_.
`here <https://www.dclunie.com/pixelmed/DICOMSR.book.pdf>`_.

Content Items
-------------
Expand Down
11 changes: 5 additions & 6 deletions docs/tid1500.rst
Original file line number Diff line number Diff line change
Expand Up @@ -737,9 +737,8 @@ highdicom test data within the highdicom repository at
)
sr_dataset.save_as("sr_document_with_multiple_groups.dcm")

.. _tid300def: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_300
.. _tid1500def: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1500
.. _tid1501def: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1501
.. _tid1410def: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1410
.. _tid1411def: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1411

.. _tid300def: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_300
.. _tid1500def: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1500
.. _tid1501def: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1501
.. _tid1410def: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1410
.. _tid1411def: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_A.html#sect_TID_1411
8 changes: 4 additions & 4 deletions src/highdicom/legacy/sop.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,16 +302,16 @@ def _convert_legacy_to_enhanced(
pass

# Cardiac Synchronization (U)
# TODO: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.7 # noqa
# TODO: https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.7 # noqa

# Contrast/Bolus Usage (U) - MR/CT only
# TODO: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.12 # noqa
# TODO: https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.12 # noqa

# Respiratory Synchronization (U)
# TODO: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.17 # noqa
# TODO: https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.17 # noqa

# Real World Value Mapping (U) - PET only
# TODO: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.11 # noqa
# TODO: https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.6.16.2.html#sect_C.7.6.16.2.11 # noqa

perframe_items.append(perframe_item)

Expand Down
2 changes: 1 addition & 1 deletion src/highdicom/valuerep.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def check_person_name(person_name: Union[str, PersonName]) -> None:
raise TypeError('Invalid type for a person name.')

name_url = (
'http://dicom.nema.org/dicom/2013/output/chtml/part05/'
'https://dicom.nema.org/dicom/2013/output/chtml/part05/'
'sect_6.2.html#sect_6.2.1.2'
)
if '^' not in person_name and person_name != '': # empty string is allowed
Expand Down