fix(CaseViewer): Address series selection for gcp #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igoroctaviano
commented
Jul 26, 2024
igoroctaviano
commented
- Users were not allowed to select series using gcp URLs: http://localhost:3000/projects/idc-dicom-review/locations/northamerica-northeast1/datasets/gtex/dicomStores/gtex/study/2.25.62074938789555554026716644355174628630/series/1.3.6.1.4.1.5962.99.1.2425336845.1080582547.1720412288013.4.0
|
Visit the preview URL for this PR (updated for commit 2d737fd): https://idc-external-006--pr226-fix-address-series-s-764be62d.web.app (expires Mon, 05 Aug 2024 12:41:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307 |
pedrokohler
requested changes
Jul 29, 2024
There was a problem hiding this comment.
@igoroctaviano please cherry-pick the following commit to solve broken unit tests 559ebce
pedrokohler
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.