Improve fellowship error (#298)

* change error * fmt
ImbueNetwork · Dec 20, 2023 · a05018f · a05018f
1 parent 2717c22
commit a05018f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pallets/briefs/src/lib.rs b/pallets/briefs/src/lib.rs
@@ -162,6 +162,8 @@ pub mod pallet {
         EoaRequiredForForeignCurrencies,
         /// Currency is not supported for this external address.
         CurrencyAccountComboNotSupported,
+        /// You must be a fellow to start this work.
+        FellowshipRequired,
     }
 
     #[pallet::call]
@@ -186,7 +188,8 @@ pub mod pallet {
             let who = ensure_signed(origin)?;
 
             if require_fellowship {
-                T::EnsureRole::ensure_role(&applicant, pallet_fellowship::Role::Freelancer, None)?;
+                T::EnsureRole::ensure_role(&applicant, pallet_fellowship::Role::Freelancer, None)
+                    .map_err(|_| Error::<T>::FellowshipRequired)?;
             }
 
             ensure!(

diff --git a/pallets/briefs/src/tests.rs b/pallets/briefs/src/tests.rs
@@ -29,7 +29,7 @@ fn create_brief_not_approved_applicant() {
                 None,
                 true,
             ),
-            BadOrigin
+            Error::<Test>::FellowshipRequired
         );
     });
 }