Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependancy issue in each pallets #252

Closed
f-gate opened this issue Oct 23, 2023 · 0 comments · Fixed by #247
Closed

Dependancy issue in each pallets #252

f-gate opened this issue Oct 23, 2023 · 0 comments · Fixed by #247
Labels
bug Something isn't working Priority | High

Comments

@f-gate
Copy link
Member

f-gate commented Oct 23, 2023

Unknown origin, looks like some pallets are missing common-runtime in their runtime-benchmarks feature.

Fix asap as its blocking generating weights for fellowship pr

@f-gate f-gate added bug Something isn't working Priority | High labels Oct 23, 2023
f-gate added a commit that referenced this issue Oct 23, 2023
@f-gate f-gate mentioned this issue Oct 23, 2023
3 tasks
f-gate added a commit that referenced this issue Oct 31, 2023
* add to runtime with dummy weights

* add genesis config

* add fellowship migration, add migration to runtime

* fix migration

* fix accountid trait bounds

* fix dependancy issue: #252

* add fellowship to runtime benchmarks

* generate fellowship weights

* remove test test

* fmt

* run gcp on all pushes

* restore

* remove genesis, add permissions, FellowshipPermissions trait

* permissions impl, mock impl

* fix tests

* organise tests, add permissions tests

* add new config to runtime

* fmt

* post upgrade test fix version err

* sanity

* sanity v2

* add context

* fmt
f-gate added a commit that referenced this issue Nov 24, 2023
* add back sudo to rococo

* runtime api

* runtime-api-wiring

* some dummy log statements

* attempt 1 to add try-runtime

* second attempt

* add to the cli

* fix warn issue

* on initialise, remove on runtime upgrade proposasl

* add the new storage version migration

* pick runtime

* new migration for proposals

* fmt

* fix v3-v4 migration test

* fix 2

* fix brief migration test

* clippy

* fmt

* new MilestoneVote implementation

* fix implementation

* get project individual votes

* remove total votes api

* fmt

* ummm

* new format for Individual votes

* boom baby, and a fmt

* clippy

* fix build

* fmt

* bump spec version

* 1

* individual votes impl with storage

* fix buggy impl

* define immutability, update on vote

* use individual votes for oninit and submit and close voting + update migration

* fixing build

* seperated test files, tested ImmutableVotes

* fix runtime api, reorg proposals

* fmt

* fmt

* clippy

* migration, err handling

* fix migration

* fmt

* fix

* clippy

* update executive and spec version

* fmt

* remove todos

* remove wrong comment

* fix failing test

* fmt

* rip the proposals changes

* merge and fix tests

* remove unused config items, reorg them, add test cases

* actually add decent documentation in pallet-proposals

* run on gcp

* bump to rebuild

* use self hosted runner

* already installed on runner

* attempt auto scaling runner

* increase disk size

* bump to build again

* dont delete at the end of the job

* remove unused directories

* bump

* change region

* split the jobs

* add -y flag

* test menually installing rust

* -y flag

* more -y

* remove double install of protobugf

* -y

* trial 1

* fix

* fix2

* fix3

* bump up

* bump

* change zone

* bump

* lol -y

* bump

* bump 2

* set home directory

* try to run as user

* init commit

* commit 2

* test

* test 3

* attempt 4

* bump

* bump

* bump

* bump

* bump

* reduce image size

* bump

* bump

* bump again

* add clippy

* build essentials

* lock

* clang

* refactor

* typo

* typo 2

* make zone configurable

* project voting data api (#224)

* add back sudo to rococo

* runtime api

* runtime-api-wiring

* some dummy log statements

* attempt 1 to add try-runtime

* second attempt

* add to the cli

* fix warn issue

* on initialise, remove on runtime upgrade proposasl

* add the new storage version migration

* pick runtime

* new migration for proposals

* fmt

* fix v3-v4 migration test

* fix 2

* fix brief migration test

* clippy

* fmt

* new MilestoneVote implementation

* fix implementation

* get project individual votes

* remove total votes api

* fmt

* ummm

* new format for Individual votes

* boom baby, and a fmt

* clippy

* fix build

* fmt

* bump spec version

* 1

* individual votes impl with storage

* fix buggy impl

* define immutability, update on vote

* use individual votes for oninit and submit and close voting + update migration

* fixing build

* seperated test files, tested ImmutableVotes

* fix runtime api, reorg proposals

* fmt

* fmt

* clippy

* migration, err handling

* fix migration

* fmt

* fix

* clippy

* update executive and spec version

* fmt

* remove todos

* remove wrong comment

* fix failing test

* fmt

* run on gcp

* bump to rebuild

* use self hosted runner

* already installed on runner

* attempt auto scaling runner

* increase disk size

* bump to build again

* dont delete at the end of the job

* remove unused directories

* bump

* change region

* split the jobs

* add -y flag

* test menually installing rust

* -y flag

* more -y

* remove double install of protobugf

* -y

* trial 1

* fix

* fix2

* fix3

* bump up

* bump

* change zone

* bump

* lol -y

* bump

* bump 2

* set home directory

* try to run as user

* init commit

* commit 2

* test

* test 3

* attempt 4

* bump

* bump

* bump

* bump

* bump

* reduce image size

* bump

* bump

* bump again

* add clippy

* build essentials

* clang

* refactor

* typo

* typo 2

* make zone configurable

---------

Co-authored-by: samelamin <[email protected]>

* refactoring

* mark the no_confidence as deprecated with the introduction of pallet-disputes

* migration for new fields

* add to runtime with dummy weights

* add genesis config

* removed everything about no-confidence logic

* fixed the format check as it was failing in the build

* add fellowship migration, add migration to runtime

* move migration to v7 after rococo upgrade

* fix migration

* fix accountid trait bounds

* fix dependancy issue: #252

* add fellowship to runtime benchmarks

* generate fellowship weights

* remove test test

* fmt

* add jury selector trait

* run gcp on all pushes

* restore

* select a random jury given a jury length

* fix randomer

* select jury tests

* refactor minor

* remove genesis, add permissions, FellowshipPermissions trait

* permissions impl, mock impl

* fix tests

* organise tests, add permissions tests

* add new config to runtime

* fmt

* add jury selector into migration

* dispute hooks draft, pallet-dispute in runtime

* raise disputes and hooks skeleton

* forgot

* trait bounds impl, todos

* bugs

* fix

* tests

* track dispute per milestone instead of per project

* minor fixes

* update withdrawn to use is_withdrawn

* fix

* fix

* more todos! Jury selector fix

* tests, refund extrinsic

* mindbending fix

* try_mutate_exists instead

* fixing just keep fixing

* another one

* marching

* my fingers hurt

* green stuff has appeared!

* grants fixes

* fixrs

* fix

* optimise refund extrinsics

* add non zero arith check, deposit event, refund benchmark

* fix

* raise dispute benchmark

* migration madness

* fix migration and tests

* jury selector move around

* fix bloomin proposals

* fix briefs

* fix grants

* fiix runtime

* fix integration test, rewrite get jury

* generate dispute weights

* fix all but deposits

* fix xcm tranfers

* trying

* fix grants benchmark tests

* fix for proposal benchmark tests

* cargo fmt

* fix for failing benchmark tests

* audit warnings

* minor fix

* remove generic param for run to block felloship

* clippy

* weights

* proposal benchmark fixes + weights

* change balance type proposals mock to u128 to prevent overflow

* fmt

---------

Co-authored-by: samelamin <[email protected]>
Co-authored-by: Shankar Rao Mata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority | High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant