Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modular characters #195

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

erdOne
Copy link
Contributor

@erdOne erdOne commented Nov 4, 2024

Co-authored-by: Yaël Dillies
Co-authored-by: Javier López-Contreras

@erdOne erdOne marked this pull request as ready for review November 4, 2024 16:29
@Ruben-VandeVelde
Copy link
Contributor

Please add the copyright header

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot the most important statement! μ (g • s) = modularHaarChar A g • μ s

Also, you should update the Co-authored-by

@erdOne
Copy link
Contributor Author

erdOne commented Nov 5, 2024

We forgot the most important statement! μ (g • s) = modularHaarChar A g • μ s

Not entirely sure what's the right typeclass to add to get this. I've added [IsFiniteMeasureOnCompacts μ] [Regular μ] for now and I hope we have this in our application.

@kbuzzard
Copy link
Collaborator

kbuzzard commented Nov 6, 2024

I bumped mathlib and broke this PR. Sorry! Error is

'MeasureTheory.Measure.addHaarScalarFactor_eq_mul' has already been declared

in FLT.Mathlib.MeasureTheory.Measure.Haar.Unique .

@YaelDillies
Copy link
Collaborator

YaelDillies commented Nov 6, 2024

I believe that's just Andrew having been super efficient with upstreaming 😁 You can simply delete the FLT.Mathlib.MeasureTheory.Measure.Haar.Unique file and replace it by Mathlib.MeasureTheory.Measure.Haar.Unique where it is imported

@pitmonticone
Copy link
Collaborator

Done.

@YaelDillies
Copy link
Collaborator

Can you run lake exe mk_all?

@pitmonticone
Copy link
Collaborator

Done.

@kbuzzard
Copy link
Collaborator

kbuzzard commented Nov 9, 2024

Thanks!

@kbuzzard kbuzzard merged commit c982409 into ImperialCollegeLondon:main Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants