Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more rational workflows for testing and publishing #88

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Oct 1, 2024

The workflows are now split:

  • One testing only in windows and linux with one python version, to run on a regular basis.
  • Another one that test in the full matrix of OS and python versions, only to run when creating a new release.

Support for python 3.8 has been dropped and for 3.12 added.

The pre-commit job has been removed and pre-commit re-enabled (as it had been disabled, at some point).

Running flake8 as precommit was producing several false-errors, so I've disabled it. It will be ditched when implementing #73 , so not a big loss.

Close #75
Close #76
Close #85

Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me! Should you also add timeouts to the workflows?

@dalonsoa dalonsoa merged commit b81f299 into develop Oct 1, 2024
4 checks passed
@dalonsoa dalonsoa deleted the ci branch October 1, 2024 11:37
@dalonsoa
Copy link
Collaborator Author

dalonsoa commented Oct 1, 2024

Good point! I forgot about those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants