Add CSV Dialect pydantic class
#93
Merged
+294
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
approved these changes
Oct 1, 2024
# Conflicts: # poetry.lock
# Conflicts: # poetry.lock
Co-authored-by: Alex Dewar <[email protected]>
AdrianDAlessandro
approved these changes
Oct 1, 2024
setup.cfg
Outdated
| @@ -8,7 +8,7 @@ test = pytest | |||
|
|
|||
| [tool:pytest] | |||
| addopts = | |||
| -v --mypy -p no:warnings | |||
| -v -p no:warnings | |||
There was a problem hiding this comment.
Why remove the pytest-mypy checks?
There was a problem hiding this comment.
A mistake, should not have been committed. Having said that, if that flag is ther,e the test discovery of VSCode does not work as it should.
# Conflicts: # poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used, eventually, to validate the part of the header that indicates the dialect. It incorporates a few shortcuts to get some common CSV dialect configurations, as exposed by the python built-in package
csv.This functionality is not used anywhere, yet. It will be used later, when implementing #79 and then #80 #81 #82 and #84
Close #2