Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution order based on variables #548

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Execution order based on variables #548

wants to merge 10 commits into from

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Sep 5, 2024

Description

Replaces the current calculation of the model execution order in init and update - based on the input configuration - with another one based on the information on which variables each model initialises and which ones they require.

Using this method has identified also an inconsistency in the variables used by the soil model, which I guess it is a good thing!

The depends section of the example config files have been removed, and I had not spotted it being mentioned anywhere else, including the documentation, but let me know if I missed anything.

In principle, this is the last bit of the implementation of the variables system.

Fixes #389

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@dalonsoa dalonsoa marked this pull request as ready for review September 5, 2024 10:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (8097392) to head (2842194).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #548   +/-   ##
========================================
  Coverage    95.04%   95.05%           
========================================
  Files           74       74           
  Lines         4262     4269    +7     
========================================
+ Hits          4051     4058    +7     
  Misses         211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Variables (umbrella)
4 participants