-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution order based on variables #548
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #548 +/- ##
========================================
Coverage 95.04% 95.05%
========================================
Files 74 74
Lines 4262 4269 +7
========================================
+ Hits 4051 4058 +7
Misses 211 211 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Replaces the current calculation of the model execution order in init and update - based on the input configuration - with another one based on the information on which variables each model initialises and which ones they require.
Using this method has identified also an inconsistency in the variables used by the
soil
model, which I guess it is a good thing!The
depends
section of the example config files have been removed, and I had not spotted it being mentioned anywhere else, including the documentation, but let me know if I missed anything.In principle, this is the last bit of the implementation of the variables system.
Fixes #389
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks