feat: add examples folder #48
Conversation
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
| """ | ||
| try: | ||
| subprocess.run( | ||
| ["docker-compose", "-f", self.compose_file, *command], |
There was a problem hiding this comment.
on my m1 system, I run docker compose not docker-compose on the command line.
There was a problem hiding this comment.
Ah, right. Fun lol. I'll try to figure out if there's a straightforward way to account for that.
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe a silly comment along these lines, @dbluhm wasn't this mentioned during the ACA-Pug meeting today? Might be able to be reconciled in the future (very possible I'm off on this)
There was a problem hiding this comment.
I'm thinking it might be simplest to just alias docker-compose for docker compose locally if you want to run these directly. Else, we can always just let the action run it and not worry about local environments.
There was a problem hiding this comment.
Not sure I heard mention of docker-compose vs docker compose on the ACA-PUG call today 🤔
There was a problem hiding this comment.
Ah, no wait you're right, I was confusing it with the amd vs. arm thingy/separate thing, my bad
This PR restructures the project to include an
examplesfolder. The examples folder will be the home for all newly created examples and will help address the issue we currently have right now where we have branches for different examples and tests. For example, once this is merged, I will restructure #7 to be just another folder in the examples directory.This PR also includes a new github action for making sure the examples are working as expected. This should help us in our efforts to check for breaking changes in new ACA-Py releases.