fix: filter for DIDCommMessaging service type #27
Conversation
This prevents exceptions that may occur if the service type is did-communication instead of DIDCommMessaging Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
|
Looks like the error is coming from black@stable |
|
Yeah, seen this in a few other repo's GHA. There's a mismatch between what's installed by the project and what the action is using. We should probably pin to the same version in the action as we're using locally to prevent this kind of issue. |
| if did_service.type != "DIDCommMessaging": | ||
| continue |
There was a problem hiding this comment.
Technically, did-communication could be used to identify a DIDComm v2 endpoint. We could consider supporting it if the accept property has didcomm/v2 in it. I haven't fully formed an opinion either way on this yet. Thoughts?
There was a problem hiding this comment.
Since the DIDComm spec encourages DIDCommMessaging, I feel that we should encourage it as well. You brought up an excellent point of making the class more modular in the future in slack, which I think is an excellent idea. Though I'm not sure when we should do that
This prevents exceptions that may occur if the service type is did-communication instead of DIDCommMessaging