Removed docker prefix usage from Nightly #539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hence ibn40 is added already as part of build (e.g., k3d-iff.localhost:12345/ibn40/scorpio-all-in-one-runner:v0.6.0-beta.1), the sed command fails to create correct name for ibn40 docker push for nightly.
Eg: DOCKER_PREFIX=ibn40
Current:
newimage=$(echo k3d-iff.localhost:12345/ibn40/scorpio-all-in-one-runner:v0.6.0-beta.1 | sed -r "s/:${DOCKER_TAG}/:latest/g" | sed -r "s/k3d-iff.localhost:12345/$(DOCKER_PREFIX)/g");
Output: ibn40/ibn40/scorpio-all-in-one-runner:latest - Fails to push because of two ibn40.
Proposed Change
newimage=$(echo k3d-iff.localhost:12345/ibn40/scorpio-all-in-one-runner:v0.6.0-beta.1 | sed -r "s/:${DOCKER_TAG}/:latest/g" | sed -r "s/k3d-iff.localhost:12345\///g");
Output: ibn40/scorpio-all-in-one-runner:latest - Push must work.