WeatherService: Prevent adding of expired events

Before further parsing of the packet, check timestamp and expires field
right after it has been decoded to avoid unnecessary allocs/frees. Also
perform tidying up of the vector before attempting to add any new
elements.

src/components/ble/weather/WeatherService.cpp

@@ -66,6 +66,14 @@ namespace Pinetime {
           CleanUpQcbor(&decodeContext);
           return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
         }
+
+        // Do not add already expired events
+        uint64_t currentTimestamp = GetCurrentUnixTimestamp();
+        if (static_cast<uint64_t>(tmpTimestamp + tmpExpires) < currentTimestamp) {
+          CleanUpQcbor(&decodeContext);
+          return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
+        }
+
         int64_t tmpEventType = 0;
         QCBORDecode_GetInt64InMapSZ(&decodeContext, "EventType", &tmpEventType);
         if (QCBORDecode_GetError(&decodeContext) != QCBOR_SUCCESS || tmpEventType < 0 ||
@@ -74,6 +82,8 @@ namespace Pinetime {
           return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
         }
 
+        TidyTimeline();
+
         switch (static_cast<WeatherData::eventtype>(tmpEventType)) {
           case WeatherData::eventtype::AirQuality: {
             std::unique_ptr<WeatherData::AirQuality> airquality = std::make_unique<WeatherData::AirQuality>();
@@ -363,9 +373,9 @@ namespace Pinetime {
           }
         }
 
+        std::sort(std::begin(timeline), std::end(timeline), CompareTimelineEvents);
+
         QCBORDecode_ExitMap(&decodeContext);
-        GetTimelineLength();
-        TidyTimeline();
 
         if (QCBORDecode_Finish(&decodeContext) != QCBOR_SUCCESS) {
           return BLE_ATT_ERR_INSUFFICIENT_RES;