Refactoring of CheckBoxList : remove dependency to SettingController #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g has changed. This allow to remove the dependency between CheckBoxList (UI component) with SettingController.
|
For #1339 it would be good to allow any values behind the options (in this case WatchFaces). We could add this with a generic type. Instead of calculating the selected value directly from the index of the option, we would also need an array of values of the generic type corresponding to the options. I am relatively new to C++ so I can not provide meaningful feedback to your changes, sorry. |
Avamander
approved these changes
Oct 4, 2022
NeroBurner
reviewed
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not completely satisfied of the design of CheckBoxList. It currently depends on SettingsController and receives pointers to function to get and set the setting.
CheckBoxList is a UI component that we should be able to use anywhere. But the current implementation limit the usage of this class to settings that are handled by the
Settingscontroller.I tried to refactor this class : it now receives the
originalValue(which is used to select the corresponding checkbox) and astd::functionthat is called when the value changes. This allows to completely de-coupleCheckBoxListfromSettings.Now, I know that lambda with capture and std::function can have a big overhead (heap allocation, binary size and execution time). I couldn't find any in this specific case, but I wouldn't mind someone cross-checking this!
Any feedback about this refactoring?