-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
background for analog watch face in lvgl #1824
Conversation
This commit removes the background image for the WatchFaceAnalog and replaces it with lvgl widgets. It aims to keep the original look.
Build size and comparison to main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You should just be able to remove the bg_clock.c file from CMakeLists.txt, then delete the file itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like this with the current colours. It might be nice to keep the 'PineTime' text, but I'm not sure we have the right font to make it look good. I would like some other people's opinions on how it looks before I approve this.
I tried it with 'PineTime' first and can confirm that it does not look good with the current font 😄 |
It would be interesting what the ram usage at runtime difference between this new and the old one with the background image is |
Which number do you need? Memory heap |
It would be better to use a label to display the current free memory on the watch face itself, because the face is unloaded when you go to the about page to look at the memory. (assuming you don't have a debugger connected) |
Makes sense. How can I get the current free memory? |
|
Personally, I would like Fredoka 600 from Google Fonts. |
Tbh, I like the watch face more without some brand label. Isn't it also possible (or at least a goal) to run InfiniTime on non-PineTime watches? |
You're right, it is possible to run InfiniTime on other watches, currently only variations of the Colmi P8. |
Great Job ! |
Here are the measurements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new implementation of the watch face looks good! I think the small visual differences are very much compensated by the amount of freed flash memory!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
* change background image to widgets This commit removes the background image for the WatchFaceAnalog and replaces it with lvgl widgets. It aims to keep the original look. * remove comments and background image --------- Co-authored-by: minacode <[email protected]>
Alternative to #1819.
This commit removes the background image for the WatchFaceAnalog and replaces it with lvgl widgets. It aims to keep the original look.
The refresh is almost instant now.
I am not sure at how much places the background image has to be removed. If someone knows more about that, please have a look at it.
Colors are up to debate 😁