Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchface: Numerals #2047

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Watchface: Numerals #2047

wants to merge 15 commits into from

Conversation

liamcharger
Copy link
Contributor

@liamcharger liamcharger commented Mar 30, 2024 •
edited
Loading

This PR adds a Numeral watch face, with inspiration from Apple Watch's numeral watch face. An image is attached below.
InfiniSim_2024-03-31_045911

@liamcharger liamcharger changed the title Numeral watch face Watchface: Numerals Mar 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 30, 2024 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 375856B 1328B
data 948B 0B
bss 63488B 0B

@NeroBurner NeroBurner added the new watchface This thread is about a new watchface label Oct 1, 2024
mark9064
mark9064 reviewed Oct 26, 2024
View reviewed changes
Copy link
Contributor

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from the screenshot! I'll give this a test run after any changes from feedback are in

src/resources/resources.json Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceNumerals.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceNumerals.cpp Show resolved Hide resolved
src/displayapp/screens/WatchFaceNumerals.cpp Show resolved Hide resolved
@mark9064
Copy link
Contributor

I'll test this on my PT shortly and review after

mark9064
mark9064 suggested changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font ranges at the moment are very large, and the watchface cannot load (too much memory)

With these changes it works and everything seems as expected 😄

src/resources/fonts.json Outdated Show resolved Hide resolved
src/resources/fonts.json Outdated Show resolved Hide resolved
@liamcharger
Copy link
Contributor Author

Gotcha, I'll make a commit when I have the chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark9064 mark9064 mark9064 requested changes

Assignees
No one assigned
Labels
new watchface This thread is about a new watchface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamcharger @mark9064 @NeroBurner