Remove unused pointer to DisplayApp member variables #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
NeroBurner
force-pushed
the
remove_unused_app_member
branch
from
e61860b
to
d1a0377
Compare
|
build error because of unused variable, removing |
In the screens that use `DisplayApp *app` and pass it to a child item, or use the reference just in the constructor. Afterwards the `app` member is not used. So remove it from the private member variables. Completely remove `app` parameter from `SettingDisplay` constructor as it is unused.
NeroBurner
force-pushed
the
remove_unused_app_member
branch
from
d1a0377
to
a202a3f
Compare
mark9064
approved these changes
Sep 18, 2024
headblockhead
added a commit
to headblockhead/InfiniTime
that referenced
this pull request
Oct 4, 2024
* Remove unused pointer to DisplayApp member variables (InfiniTimeOrg#2125) In the screens that use `DisplayApp *app` and pass it to a child item, or use the reference just in the constructor. Afterwards the `app` member is not used. So remove it from the private member variables. Completely remove `app` parameter from `SettingDisplay` constructor as it is unused. * MusicService: add missing includes for TickType_t and xTaskGetTickCount (InfiniTimeOrg#2130) Add `FreeRTOS.h` include for the directly used data type `TickType_t` in the header and the function `xTaskGetTickCount` from FreeRTOS's `task.h` * settings: Add global widget selection Instead of each watch face implementing their own settings for which widgets to display, we can have a global selection of widgets. All watch faces can then determine whether it is enabled and so display it in whichever way makes sense for that face. Current widgets supported are heart rate, step counter, and weather. * WatchFaceAnalog: Add configurable widgets * WatchFaceAnalog: Add weather widget --------- Co-authored-by: NeroBurner <[email protected]> Co-authored-by: Victor Kareh <[email protected]>
headblockhead
added a commit
to headblockhead/InfiniTime
that referenced
this pull request
Oct 4, 2024
* Remove unused pointer to DisplayApp member variables (InfiniTimeOrg#2125) In the screens that use `DisplayApp *app` and pass it to a child item, or use the reference just in the constructor. Afterwards the `app` member is not used. So remove it from the private member variables. Completely remove `app` parameter from `SettingDisplay` constructor as it is unused. * MusicService: add missing includes for TickType_t and xTaskGetTickCount (InfiniTimeOrg#2130) Add `FreeRTOS.h` include for the directly used data type `TickType_t` in the header and the function `xTaskGetTickCount` from FreeRTOS's `task.h` * BatteryIcon: Change color with charge percentage --------- Co-authored-by: NeroBurner <[email protected]> Co-authored-by: Victor Kareh <[email protected]>
headblockhead
added a commit
to headblockhead/InfiniTime
that referenced
this pull request
Oct 4, 2024
* Remove unused pointer to DisplayApp member variables (InfiniTimeOrg#2125) In the screens that use `DisplayApp *app` and pass it to a child item, or use the reference just in the constructor. Afterwards the `app` member is not used. So remove it from the private member variables. Completely remove `app` parameter from `SettingDisplay` constructor as it is unused. * MusicService: add missing includes for TickType_t and xTaskGetTickCount (InfiniTimeOrg#2130) Add `FreeRTOS.h` include for the directly used data type `TickType_t` in the header and the function `xTaskGetTickCount` from FreeRTOS's `task.h` * Improved the Terminal Watchfaces UI + Reorder code to match the widgets order in the UI. + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore. --------- Co-authored-by: NeroBurner <[email protected]> Co-authored-by: JustScott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the screens that use
DisplayApp *appand pass it to a child item, or use the reference just in the constructor. Afterwards theappmember is not used. So remove it from the private member variables.SettingDisplay.hactually never usesDisplayApp *appand the parameter could be removed from the constructor. I'd be happy about feedback whether or not to remove it.Completely remove
appparameter fromSettingDisplayconstructor as it is unused.