-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gesture consistency across the firmware #720
Improve gesture consistency across the firmware #720
Conversation
I don't see a reason to even have a "swipe to close" gesture, that's what the button is for and it avoids all of the inconsistency and by now also avoid changes people have to get reaccustomed to. |
Pressing the button is inconvenient and I don't see how this creates any changes that require getting accustomed to. |
Matter of personal preference then.
I have to be more precise in Music because I can accidentally exit it. I don't want that because the intention of gestures is that looking at the screen would not be necessary to control everything necessary. |
Swiping left and right go to the previous and next song, but swiping up and down don't directly affect anything, they just change the buttons. You'd still need to look at the screen to press the buttons. I don't think swiping to change the buttons is that great in the first place, but that's another topic. |
You don't actually because there's a gesture. |
I don't see a gesture for controlling the volume. Also are we still talking about the up/down gestures, which I also believe only affect the buttons? |
That bothered me many times, thanks. And that is mainly that flashlight starts by accident :) I never used it.
I love swipe down to exit. When you have to press the button you have to use two fingers to support the watch from the right side to press button from the left side it correctly. I have quite a loose wachband. Regarding the Music buttons, I also don't like switching between volume and prev/next arrows. We might get rid of rotating turntable animation and add buttons there, so they could be visible all the time. Or just keep next/prev for gestures.. That's fro another PR. |
Tested and works fine, thanks for this usage improvement! |
hi , maybe @hubmartin @Riksu9000 you could put the music screen on the exclusion list ( like for 2048, paint ) for example? by the way , since i use for the long time the music screen i have grown quite accustomed to switching to volume since with the gesture . i think that the way to close all app should be selectable with a menu |
@lman0 You can still swipe up in the Music app for Volume and swipe down for previous/next buttons. This stayed the same. |
i'm thinking that should be reviewed by @Avamander or @geekbozu since it might help give unity to the UI . |
I have been using this pr for over a month and it makes using InfiniTime much more pleasant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great!
Squashed commit of the following: commit 0f893c4 Author: Riku Isokoski <[email protected]> Date: Mon Oct 4 11:32:50 2021 +0300 Add missing break commit 36c86a1 Author: Riku Isokoski <[email protected]> Date: Mon Oct 4 11:13:45 2021 +0300 Improve gesture consistency across the firmware
Looks good to me, thanks @Riksu9000 ! |
Metronome can be closed by swiping down from the center. I could make it not close while dragging the arc, but I couldn't make it not close while dragging the dropdown menu, so this is the next best thing.
Music app shows volume buttons on swipe up and swiping down goes back to next/prev. now swiping down in the default state will close the app.
Flashlight can now be closed by swiping down. Also the transitions animation was changed to match other apps and returnapp is quicksettings instead of watchface.
The last apps that can't be closed through the touchscreen are Paint, Paddle and Twos, but they can't easily be made to use swipes for closing, so they would need some other solution.
Closes #651, unless we keep it open for these three.
VID_20211004_111219.mp4