Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gesture consistency across the firmware #720

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Improve gesture consistency across the firmware #720

merged 2 commits into from
Dec 30, 2021

Conversation

Riksu9000
Copy link
Contributor

Metronome can be closed by swiping down from the center. I could make it not close while dragging the arc, but I couldn't make it not close while dragging the dropdown menu, so this is the next best thing.

Music app shows volume buttons on swipe up and swiping down goes back to next/prev. now swiping down in the default state will close the app.

Flashlight can now be closed by swiping down. Also the transitions animation was changed to match other apps and returnapp is quicksettings instead of watchface.

The last apps that can't be closed through the touchscreen are Paint, Paddle and Twos, but they can't easily be made to use swipes for closing, so they would need some other solution.

Closes #651, unless we keep it open for these three.

VID_20211004_111219.mp4

@Avamander
Copy link
Collaborator

I don't see a reason to even have a "swipe to close" gesture, that's what the button is for and it avoids all of the inconsistency and by now also avoid changes people have to get reaccustomed to.

@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Oct 4, 2021

I don't see a reason to even have a "swipe to close" gesture, that's what the button is for and it avoids all of the inconsistency and by now also avoid changes people have to get reaccustomed to.

Pressing the button is inconvenient and I don't see how this creates any changes that require getting accustomed to.

@Avamander
Copy link
Collaborator

Pressing the button is inconvenient

Matter of personal preference then.

I don't see how this creates any changes to get accustomed to.

I have to be more precise in Music because I can accidentally exit it. I don't want that because the intention of gestures is that looking at the screen would not be necessary to control everything necessary.

@Riksu9000
Copy link
Contributor Author

I have to be more precise in Music because I can accidentally exit it. I don't want that because the intention of gestures is that looking at the screen would not be necessary to control everything necessary.

Swiping left and right go to the previous and next song, but swiping up and down don't directly affect anything, they just change the buttons. You'd still need to look at the screen to press the buttons. I don't think swiping to change the buttons is that great in the first place, but that's another topic.

@Avamander
Copy link
Collaborator

You'd still need to look at the screen to press the buttons.

You don't actually because there's a gesture.

@Riksu9000
Copy link
Contributor Author

You'd still need to look at the screen to press the buttons.

You don't actually because there's a gesture.

I don't see a gesture for controlling the volume. Also are we still talking about the up/down gestures, which I also believe only affect the buttons?

@geekbozu geekbozu added the enhancement Enhancement to an existing app/feature label Oct 4, 2021
@hubmartin
Copy link
Contributor

Flashlight can now be closed by swiping down.

That bothered me many times, thanks. And that is mainly that flashlight starts by accident :) I never used it.

Pressing the button is inconvenient
Matter of personal preference then.

I love swipe down to exit. When you have to press the button you have to use two fingers to support the watch from the right side to press button from the left side it correctly. I have quite a loose wachband.

Regarding the Music buttons, I also don't like switching between volume and prev/next arrows. We might get rid of rotating turntable animation and add buttons there, so they could be visible all the time. Or just keep next/prev for gestures.. That's fro another PR.

@hubmartin
Copy link
Contributor

Tested and works fine, thanks for this usage improvement!

@lman0
Copy link

lman0 commented Oct 4, 2021

hi , maybe @hubmartin @Riksu9000 you could put the music screen on the exclusion list ( like for 2048, paint ) for example?

by the way , since i use for the long time the music screen i have grown quite accustomed to switching to volume since with the gesture .
like @Avamander said , it's a matter of preference .

i think that the way to close all app should be selectable with a menu
because i know some people that have phone from sailfishos , other from phosh (linux) , android or apple and
each os have the way to close app (some with up gesture, other with down ...)

@hubmartin
Copy link
Contributor

@lman0 You can still swipe up in the Music app for Volume and swipe down for previous/next buttons. This stayed the same.
I also use Music app the most time, tested it now and it is a good solution.

@lman0
Copy link

lman0 commented Oct 29, 2021

i'm thinking that should be reviewed by @Avamander or @geekbozu since it might help give unity to the UI .

@Itai-Nelken
Copy link
Contributor

Itai-Nelken commented Dec 1, 2021

I have been using this pr for over a month and it makes using InfiniTime much more pleasant.

Copy link
Member

@geekbozu geekbozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!

FintasticMan added a commit to FintasticMan/InfiniTime that referenced this pull request Dec 13, 2021
Squashed commit of the following:

commit 0f893c4
Author: Riku Isokoski <[email protected]>
Date:   Mon Oct 4 11:32:50 2021 +0300

    Add missing break

commit 36c86a1
Author: Riku Isokoski <[email protected]>
Date:   Mon Oct 4 11:13:45 2021 +0300

    Improve gesture consistency across the firmware
@JF002
Copy link
Collaborator

JF002 commented Dec 30, 2021

Looks good to me, thanks @Riksu9000 !

@JF002 JF002 merged commit 54f588c into InfiniTimeOrg:develop Dec 30, 2021
@JF002 JF002 added this to the 1.8.0 milestone Dec 30, 2021
@medeyko medeyko mentioned this pull request Jan 12, 2022
@Riksu9000 Riksu9000 deleted the improve_gesture_consistency branch January 21, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent interface in InfiniTime 1.4.0
7 participants