Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashlight brightness control #740

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Flashlight brightness control #740

merged 1 commit into from
Oct 23, 2021

Conversation

Riksu9000
Copy link
Contributor

At first I was planning on fixing #702 a different way #735 (comment), but then I found that brightness control can actually be useful in pitch black #735 (comment).

This PR adds adjustable brightness control to the flashlight app. The default brightness level will be the current backlight level.

By default the flashlight will be off, so it won't blind the user on launch.

The brightness control affects the backlight while the flashlight is disabled, which should make the icon dim enough that it isn't an issue.

Also added swipe down to exit and changed return app to QuickSettings.

If we find that a red flashlight color is actually usable and beneficial in some use case, that could be added behind a long press.

After recording this video, I changed the opening animation to a slide up, like the other apps.

Fixes half of #702. Shake algorithm should be added later.

VID_20211013_125548.mp4

@geekbozu
Copy link
Member

I quite like this, This also might benefit from #575 once that gets closer to completion!

@Itai-Nelken
Copy link
Contributor

I have been using this pr for a few days, and it works great! the flashlight app is much more usable and pleasant to use.
A suggestion:
Usually when I open the flashlight app is because I want to use it, and the extra tap to turn it on is sometimes annoying.
I understand why it's good to have it open off, especially with the ghost touches issue. so maybe make it a setting (though the settings already feel cluttered on latest develop...)?

@JF002
Copy link
Collaborator

JF002 commented Oct 23, 2021

Awesome, thanks!

@JF002 JF002 merged commit 6c3f56b into InfiniTimeOrg:develop Oct 23, 2021
@Riksu9000 Riksu9000 deleted the flashlight_brightness branch October 23, 2021 10:02
@Riksu9000 Riksu9000 mentioned this pull request Oct 31, 2021
@medeyko
Copy link
Contributor

medeyko commented Nov 17, 2021

It's great that the torch is now ajustable, but personally for me it has became much less usable.

I often use it to routinely light a room. For this I need a torch that lights at maximum level with minimum gestures.

The old version (firmware 1.6.0) required only TWO gestures: 1. swipe left for menu; 2. click on the torch icon.
Now (1.7.1) I have to make FIVE gestures: 1. swipe left for menu; 2. click on the torch icon; 3. swipe left to increase light; 4. swipe right to increase light; 5. click to turn the torch on.

This is quite inconvient. I would like to either have an opportuninty to set the default light level to maximum and the torch state to on, or have some other short sequence (of no more than two gestures) that allows to turn the torch on maximum.

Also it's a pity that requests to support RED color were rejected. There are lot cases when low-energy photons are preferable, like photograhy or astronomy. Also, the red color is used to draw attention. Namely, I would use red torch when walking by roadside. It might be just a fourth "light level" option, a red one after three white ones.

For the latter use case, it would be nice to have a strobe ligth option for (it draws more attention and conserves battery power), but probably it's another topic for discussion.

(Please point where to post my comment if I chose the wrong place.)

@Riksu9000
Copy link
Contributor Author

@medeyko A new issue would be the best place to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants