fix: Honor struct tags on WriteData and avoid panic for unexported fields #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the current implementation, the
WriteData
function will check the tagged structure before processing it. This has the drawback that the function will error out for invalid fields even though those fields are not meant to be exported by either being taggedlp:"-"
or by not being tagged at all.Furthermore, the current code panics for unexported fields because
Interface()
will panic on those fields (see documentation).This PR moves the structure checks to a point where we can be sure that the field needs to be exported. Furthermore, the PR handles tagged unexported fields without panic.
Checklist