Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom default HTTP headers support #30

Merged
merged 6 commits into from
Aug 10, 2023
Merged

feat: add custom default HTTP headers support #30

merged 6 commits into from
Aug 10, 2023

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Aug 3, 2023 •
edited
Loading

With #31 merged-in

Proposed Changes

Adds custom (default) HTTP headers support.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #30 (27429d2) into main (0dad3dd) will increase coverage by 2.76%.
The diff coverage is 78.36%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   78.59%   81.35%   +2.76%     
==========================================
  Files           8        9       +1     
  Lines         528      574      +46     
==========================================
+ Hits          415      467      +52     
+ Misses         97       93       -4     
+ Partials       16       14       -2
Files Changed Coverage Δ
influxdb3/point.go 100.00% <ø> (ø)
influxdb3/reflection.go 50.00% <ø> (ø)
influxdb3/query_iterator.go 43.26% <43.26%> (ø)
influxdb3/query.go 81.81% <81.81%> (ø)
influxdb3/write.go 97.56% <97.56%> (ø)
influxdb3/client.go 91.58% <100.00%> (ø)
influxdb3/error.go 100.00% <100.00%> (ø)
influxdb3/fix_url.go 100.00% <100.00%> (ø)
influxdb3/query_type.go 100.00% <100.00%> (ø)

@alespour alespour requested a review from bednar August 3, 2023 13:31
@alespour alespour marked this pull request as ready for review August 3, 2023 15:00
alespour and others added 3 commits August 3, 2023 17:08
@alespour
docs: fix PR reference
88b39f7
@alespour
docs: fix pull request ref in CHANGELOG
55fd7c9
@alespour @bednar
fix: uniform client API (#31)
27429d2 
* fix: refactor to uniform API

* refactor: change package to influxdb3

* refactor: rename client_write file to just write

* refactor: add query and write methods with options

* fix: remove Query method parameter with unclear meaning and no tests

Co-authored-by: Jakub Bednář <[email protected]>
@alespour alespour merged commit b063df4 into main Aug 10, 2023
10 of 11 checks passed
@alespour alespour deleted the feat/custom-headers branch August 10, 2023 08:12
@alespour alespour mentioned this pull request Aug 10, 2023
Closed
6 tasks
@bednar bednar added this to the 0.2.0 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar Awaiting requested review from bednar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

refactor: database argument should be optional refactor: change signature of parameters in Query function
2 participants
@alespour @bednar