Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow better choice of viewers #798

Closed
tdudgeon opened this issue Nov 23, 2022 · 0 comments · Fixed by #882
Closed

Allow better choice of viewers #798

tdudgeon opened this issue Nov 23, 2022 · 0 comments · Fixed by #882
Assignees
Labels
enhancement New feature or request

Comments

@tdudgeon
Copy link
Contributor

The links to input and output files in job execution results (and maybe other places) always seem to use the plain text viewer.
e.g. the link takes you straight to the plain text view even though the browser view might be more appropriate.
For files in the project view you get taken to an intermediate page which lists the different types of viewer. This is more flexible but a little cumbersome as you need to click again on the intermediate page to choose your viewer.

As an interim solution it would better to always go to the intermediate page (which could also display more info about the files mime/type.

A better longer term solution might be that the clicking the first link shows a popup of the available viewers, letting you go directly, or go to the intermediate page for more info.

Also, we should aim to allow the types of viewers for a file type to be configured using the types endpoint, which contains info like this:

    {
      "file_extensions": [
        ".csv",
        ".csv.gz"
      ],
      "mime": "text/csv"
    },
    {
      "file_extensions": [
        ".tab",
        ".tab.gz"
      ],
      "mime": "text/tab-separated-values"
    },

That can be extended to allow additional viewer types and a preferred viewer to be defined. But until we have additional viewer types this is overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants