[Feature] Support the basic dbt 1.6 metric #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei-Chun, Chang <[email protected]>
Co-authored-by: wcchang <[email protected]> Signed-off-by: popcorny <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
wcchang1115
changed the title
Codecov Report
@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 47.83% 47.92% +0.08%
==========================================
Files 71 71
Lines 10021 10189 +168
==========================================
+ Hits 4794 4883 +89
- Misses 5227 5306 +79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
popcornylu
reviewed
Sep 1, 2023
|
|
||
| m = Metric(metric.get('name'), | ||
| calculation_method='derived', | ||
| expression=f"{numerator.get('name')} / {denominator.get('name')}", |
There was a problem hiding this comment.
nitpick: Would be better to pass the calculation_method & numerator & denominator to Metric object. Then generate the SQL accordingly. But now, it is fine.
There was a problem hiding this comment.
Will put it into another story to enhance
Signed-off-by: Wei-Chun, Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
sc-32064
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE