Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] sc-32261 Read GitHub PR info from env var #883

Merged

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Read GitHub PR info from GITHUB_PR_ID, GITHUB_PR_URL and GITHUB_PR_TITLE

Which issue(s) this PR fixes:
sc-32261

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

 - Read GitHub PR info from `GITHUB_PR_ID`, `GITHUB_PR_URL` and
   `GITHUB_PR_TITLE`

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome force-pushed the feature/sc-32261/cloud-append-github-pr-link-in-the-upload branch from 093242c to 0c0bfd2 Compare September 12, 2023 02:11
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #883 (0c0bfd2) into main (0a4839a) will increase coverage by 0.06%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
+ Coverage   46.41%   46.48%   +0.06%     
==========================================
  Files          75       75              
  Lines       10358    10365       +7     
==========================================
+ Hits         4808     4818      +10     
+ Misses       5550     5547       -3     
Files Changed Coverage Δ
piperider_cli/cloud_connector.py 14.96% <0.00%> (+0.12%) ⬆️
piperider_cli/githubutil.py 95.34% <90.90%> (-1.63%) ⬇️
piperider_cli/compare_report.py 31.11% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kentwelcome kentwelcome merged commit 0e3883a into main Sep 12, 2023
30 checks passed
@kentwelcome kentwelcome deleted the feature/sc-32261/cloud-append-github-pr-link-in-the-upload branch September 12, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant