Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] stop sending report when no-such-table #894

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 5, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

We can not help in this case, the remote report is useless.

Which issue(s) this PR fixes:
sc-32373

@qrtt1 qrtt1 force-pushed the bug/sc-32373/nosuchtableerror-album-2022-09-30 branch from bc222f5 to 44464d9 Compare October 5, 2023 06:45
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #894 (2a2933d) into main (893b28a) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   48.30%   48.31%           
=======================================
  Files          76       76           
  Lines       10609    10611    +2     
=======================================
+ Hits         5125     5127    +2     
  Misses       5484     5484           
Files Coverage Δ
piperider_cli/profiler/profiler.py 74.46% <25.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qrtt1 qrtt1 force-pushed the bug/sc-32373/nosuchtableerror-album-2022-09-30 branch from 951c2d2 to 1599492 Compare October 5, 2023 07:40
@qrtt1 qrtt1 requested a review from wcchang1115 October 5, 2023 07:41
@qrtt1 qrtt1 force-pushed the bug/sc-32373/nosuchtableerror-album-2022-09-30 branch from 40c8397 to a4b3cac Compare October 5, 2023 08:26
Signed-off-by: Ching Yi, Chan <[email protected]>
@qrtt1 qrtt1 force-pushed the bug/sc-32373/nosuchtableerror-album-2022-09-30 branch from a4b3cac to 2a2933d Compare October 5, 2023 08:29
@qrtt1 qrtt1 merged commit 6e36aa6 into main Oct 5, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants