Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix dbt-core breaking our task runner #895

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 5, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

add the required dbt_cloud arg

Which issue(s) this PR fixes:

sc-32397

Special notes for your reviewer:

It can not be checked by the version of dbt-core, we should ask the specific field in the dataclass

@qrtt1 qrtt1 requested a review from wcchang1115 October 5, 2023 07:13
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #895 (6c4b54f) into main (9fcacbb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   48.30%   48.31%           
=======================================
  Files          76       76           
  Lines       10609    10609           
=======================================
+ Hits         5125     5126    +1     
+ Misses       5484     5483    -1     
Files Coverage Δ
piperider_cli/dbt/list_task.py 65.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qrtt1 qrtt1 merged commit 893b28a into main Oct 5, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants