Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Escape unsupported unicode emojis for legacy windows console #908

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 20, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • in a legacy Windows console, some Unicode emojis would cause the unicode encoding error.

Which issue(s) this PR fixes:
sc-32406

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #908 (3e4496b) into main (80655ee) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   48.00%   47.98%   -0.02%     
==========================================
  Files          77       77              
  Lines       10714    10726      +12     
==========================================
+ Hits         5143     5147       +4     
- Misses       5571     5579       +8     
Files Coverage Δ
piperider_cli/validator.py 22.22% <25.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 20, 2023 09:06
@qrtt1 qrtt1 self-requested a review October 23, 2023 03:37
@wcchang1115 wcchang1115 merged commit 62890e7 into main Oct 23, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants