Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix no attributes error #920

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 30, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

Convert message from any kinds of exceptions

Which issue(s) this PR fixes:

sc-32507

Signed-off-by: Ching Yi, Chan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #920 (2bf2960) into main (bf71b4a) will increase coverage by 0.05%.
Report is 15 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   47.94%   47.99%   +0.05%     
==========================================
  Files          77       78       +1     
  Lines       10740    10759      +19     
==========================================
+ Hits         5149     5164      +15     
- Misses       5591     5595       +4     
Files Coverage Δ
piperider_cli/error.py 57.71% <0.00%> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qrtt1 qrtt1 merged commit bfc8424 into main Oct 30, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants