Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix default dbt target decision policy #926

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Nov 7, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • fix how piperider decides dbt default target

Which issue(s) this PR fixes:
sc-32560

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #926 (3b00169) into main (02b474b) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   48.48%   48.50%   +0.01%     
==========================================
  Files          63       63              
  Lines        9066     9067       +1     
==========================================
+ Hits         4396     4398       +2     
+ Misses       4670     4669       -1     
Files Coverage Δ
piperider_cli/configuration.py 60.17% <100.00%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@wcchang1115 wcchang1115 marked this pull request as ready for review November 8, 2023 07:18
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit b63d01b into main Nov 8, 2023
29 checks passed
@wcchang1115 wcchang1115 deleted the bug/sc-32560/bug-fix-piperider-default-target-decision branch November 8, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants