Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Additionaly output 8 basic terminal colors #53

Closed
junnunkarim opened this issue Feb 24, 2024 · 17 comments
Closed

[FEATURE REQUEST] Additionaly output 8 basic terminal colors #53

junnunkarim opened this issue Feb 24, 2024 · 17 comments
Labels
enhancement New feature or request

Comments

@junnunkarim
Copy link

Would it be possible to output the 8 basic terminal colors (black, red, green, yellow, blue, magenta, cyan and white) based on the wallpaper alongside the normal output?

@InioX
Copy link
Owner

InioX commented Feb 24, 2024

Hi, @junnunkarim !

I don't think I'm sure what you mean. How would the 8 static colors change based on wallpaper?

The only thing i can think of is harmonizing the colors like this?

@InioX InioX added the enhancement New feature or request label Feb 24, 2024
@junnunkarim
Copy link
Author

Hello @InioX !

I was thinking that just like how the primary, secondary and tertiary colors are generated, it would also be possible to generate those 8 colors. Sorry but I wasn't thinking deep enough. I now understand that a wallpaper might not contain all 8 colors which would create a significant issue.

Ater checking out what harmonizing colors mean, I think it might be the option that I would like to have.
But as far as I can understand, it would be necessary to first use a static set of 8 colors.
So how would you be dealing with this? How about taking those 8 colors as input alongside the wallpaper and output the harmonized colors? Or is there any better way?

@InioX
Copy link
Owner

InioX commented Feb 26, 2024

I was thinking of just adding a field for harmonized_colors inside the config file. Something like this

[config]
# ...

[config.harmonized_colors]
green = "#00FF00"
red = "#FF0000"
blue = "#0000FF"
# ...

@junnunkarim
Copy link
Author

Oh, sure. That would be totally fine.

@InioX
Copy link
Owner

InioX commented Mar 2, 2024

Sorry for the delay, I had some issues with my laptop. The colors seem a bit weird to me but everything should be implemented. Is this what you had in mind?

Configuration file

[config.colors_to_harmonize]
green = "#00FF00"
red = "#FF0000"
blue = "#0000FF"

Template file

image

Output

image

@junnunkarim
Copy link
Author

No worries and Thank you!
Yes, this is what I would like to have. (although the colors do seem a little bit weird)
But if possible would you push the changes to a branch, so that I could test this feature out?

@InioX
Copy link
Owner

InioX commented Mar 2, 2024

I forgot to push the changes, sorry about that. It is on the dev branch now.

@junnunkarim
Copy link
Author

I have tested out and it's working perfectly! Thank You!

Harmonized colors with generated colorscheme (terminal)

Showcasing harmonized colors

Would it be possible to output the harmonized colors with the json option?

@InioX
Copy link
Owner

InioX commented Mar 3, 2024

I'm happy to see that it's working like it should! Also, I like your setup.

I forgot about something AGAIN. I was gonna add it but then started working on filters... Sorry about that, I'll add it in a bit.

@junnunkarim
Copy link
Author

Thank you so much for your kind words :-)

It okay, happens to me all the time.
I will wait for that feature to be implemented before closing this issue.

@junnunkarim
Copy link
Author

Although harmonized colors were included in json but there seems to be an issue with the format it outputs in.
If I output using hex, it still outputs the harmonized colors in rgb format.

Here's the output -

"harmonized_colors": {
    "blue": [
        255,
        135,
        165,
        143
    ],
    "cyan": [
        255,
        155,
        226,
        197
    ],
    "green": [
        255,
        211,
        179,
        0
    ],
    "magenta": [
        255,
        214,
        134,
        143
    ],
    "orange": [
        255,
        255,
        125,
        83
    ],
    "red": [
        255,
        252,
        71,
        65
    ],
    "yellow": [
        255,
        255,
        185,
        101
    ]
}

@InioX
Copy link
Owner

InioX commented Mar 5, 2024

I'm starting to think I have dementia, I'll fix it.

@junnunkarim
Copy link
Author

Sorry for the pressure 😅

@InioX
Copy link
Owner

InioX commented Mar 7, 2024

Okay so, I won't be able to fix it until I either fix my laptop or buy a new pc. I'll be able to get a new pc on March 17th, sorry.

@junnunkarim
Copy link
Author

It's okay, I understand your issue. I will wait.
Good Luck getting your new pc!

@InioX
Copy link
Owner

InioX commented Mar 18, 2024

Hi, sorry for the long wait.

Some complications happened with the pc, so I wanted to try if matugen builds on android.

When running cargo install matugen everything compiles fine but when trying to cargo run in the repository, it doesn't compile and throws an error. Tried searching for the error and I haven't seen anything like it so I dunno.

I guess i could try installing a linux distro inside termux and trying to compile matugen inside of it. But that seems like too much, maybe I should just wait.

The laptop is being fixed right now and I'm giving it a week until its done, maybe even sooner. Again, sorry for the wait but I can't really do anything right now.

@junnunkarim
Copy link
Author

Thank you for letting me now.
But don't worry, there's no rush.

As for termux, I have encountered issues multiple times when compiling and running rust programs. So some time ago I just installed a proot distro and since then I can compile and run programs just fine. Issues still happen but a lot less than before. Although compiling takes quite some time, but atleast in proot I can use a native arm build of rust compiler rather than the patched one on termux.
You may want to try out TermuxArch.

Again, there's no rush, take your time. I will wait.

InioX added a commit that referenced this issue Mar 26, 2024
InioX added a commit that referenced this issue Mar 26, 2024
@InioX InioX closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants