Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation to invalid catalog causes blank screen #865

Closed
johnksv opened this issue Oct 17, 2024 · 0 comments · Fixed by #872
Closed

Navigation to invalid catalog causes blank screen #865

johnksv opened this issue Oct 17, 2024 · 0 comments · Fixed by #872

Comments

@johnksv
Copy link
Contributor

johnksv commented Oct 17, 2024

When navigation to a non-existing catalog, e.g. https://datalab.sspcloud.fr/catalog/my-non-existing-catalog , the GUI appears blank and also enters a bad state where only a refresh will remedy the situation:
image

This is due to the assertion done here: https://github.com/InseeFrLab/onyxia/blob/main/web/src/core/usecases/catalog/selectors.ts#L157

Proposal for fix is that onyxia redirects to /catalog or some other place if a invalid catalog ID is provided.
ddecrulle added a commit that referenced this issue Nov 7, 2024
@ddecrulle
fix #865
0392227
@ddecrulle ddecrulle linked a pull request Nov 7, 2024 that will close this issue
fix #865 #872
Merged
ddecrulle added a commit that referenced this issue Nov 8, 2024
@ddecrulle
fix #865
cc6ffa1
garronej added a commit that referenced this issue Nov 8, 2024
@garronej
Merge pull request #872 from InseeFrLab/fix-navigation-invalid
dd15640 
fix #865
ddecrulle added a commit that referenced this issue Nov 15, 2024
@ddecrulle
fix #865
05b12ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #865 InseeFrLab/onyxia
1 participant
@johnksv