Correct error when providing a string for http_proxy

[tfardet]

np.isnan does not support str entries so the test used to trigger an error whenever an actual value was provided

[tfardet]

Don't know if I'm supposed to do something for the tests to pass... clearly some credentials are missing but I guess it should be configured to use your secrets for PRs, right?
It runs fine on my local machine with my credentials.

[hadrilec]

Indeed I have to check how to allow external PRs to have access to repo's secrets, if you find any guideline on this let me know, in any case I will check how to do it in the coming days

[hadrilec]

I have just added you as an active contributor to this repo, let me know if it goes in the right direction

[tfardet]

Thanks, I'll try to have a look (hopefully this evening or tomorrow), I'm not sure that write access alone will change the problem, though, probably there'll be something more to do.

[tfardet]

OK, I looked around and I think pull_request_target is the way to go!
See here for a discussion about the actual code that should be used:

name: pynsee package tests

on:
  push:
      branches:
        - 'master'
  pull_request_target:
    branches:
        - 'master'

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        python-version: ["3.7", "3.8", "3.9", "3.10"]

    steps:
      - name: Checkout code
        uses: actions/checkout@v2
        with:
          ref: "refs/pull/${{ github.event.number }}/merge"

and this page for a discussion about how to make it safe.

[hadrilec]

@tfardet thanks a lot, I modified the package test yaml file following your guidelines.
I also included your bug fix in this commit d508b12
If you are working behind a proxy server, I would be happy if you could let me know if pynsee is still usable behind the proxy

[tfardet]

OK, good, closing this, then, will try to check it out ASAP and work on fixing the tests (I've already seen some strings that need to be rawstrings)