Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version #1786

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

kpgalligan
Copy link
Contributor

PR for #1785. Will let CI run to determine if everything is OK, but it should be fine.

@arnaudgiuliani arnaudgiuliani added this to the core-3.5.4 milestone Feb 15, 2024
@arnaudgiuliani arnaudgiuliani added the type:improvement Improving a current feature label Feb 15, 2024
@arnaudgiuliani
Copy link
Member

thanks 👍 I've seen someone suggesting to go 2.0.6. I'll add that quickly

@kpgalligan
Copy link
Contributor Author

@arnaudgiuliani It might actually be easier if you make the change if it's just the version bump, as I need to figure out signing of commits, but my day is pretty tight. However, there's some kind of test failure, so I may need to dive into that anyway. It is a concurrency test failure, so it seems very likely related somehow (although there really shouldn't be any functional change with version 2.0.6, so I'm not sure why there would be an issue.

@arnaudgiuliani
Copy link
Member

no worry ... macos test failures are there since a while 🙄

@arnaudgiuliani arnaudgiuliani changed the base branch from main to 3.5.4 February 22, 2024 14:50
@arnaudgiuliani arnaudgiuliani merged commit 92c6f67 into InsertKoinIO:3.5.4 Feb 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core type:improvement Improving a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants