Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker image bump #1115

Merged
merged 3 commits into from
Apr 15, 2024
Merged

docker image bump #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c69d3f
chore(docker): bump Node version to 20.12.2
thewtex Apr 15, 2024
4ea5aea
feat(itk-wasm-cli): Update default Docker image for 20240415-8c69d3f8
thewtex Apr 15, 2024
3c35017
docs(docker): document build, test as part of the image release process
thewtex Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/typescript/itk-wasm/src/cli/default-image-tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
const defaultImageTag = '20240413-b75cd2b9'
const defaultImageTag = '20240415-8c69d3f8'
export default defaultImageTag
3 changes: 3 additions & 0 deletions src/docker/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ pnpm i
./src/docker/build.sh --with-debug --multiarch
# DockerHub credential environmental variables must be set
./src/docker/push.sh

pnpm build && pnpm test

git add -- packages/core/typescript/itk-wasm/src/cli/default-image-tag.js
git commit -m "feat(itk-wasm-cli): Update default Docker image for $(date '+%Y%m%d')-$(git rev-parse --short HEAD)"
```
2 changes: 1 addition & 1 deletion src/docker/itk-wasm-base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ LABEL org.opencontainers.image.source="https://github.com/InsightSoftwareConsort
WORKDIR /

# Note: on entry, emsdk will prepend to the path with its own node, so add to an earlier path
ENV NODE_TAG v18.17.1
ENV NODE_TAG v20.12.2
RUN curl -LO https://nodejs.org/dist/${NODE_TAG}/node-${NODE_TAG}-linux-x64.tar.xz && \
tar xvJf node-${NODE_TAG}-linux-x64.tar.xz && \
rm node-${NODE_TAG}-linux-x64.tar.xz && \
Expand Down
Loading