COMP: Fix error: constexpr variable 'ImageIOFactoryRegisterRegisterList'

Replaced `constexpr` by `const` in itk*IOFactoryRegisterManager.h.in files, in order to work around ITK.Windows.Python CI errors at Azure.fv-az77-327, build Windows_NT-Build2622-master-Python (Visual Studio 2019 v16.11.4, MSVC 19.29.30136.0) at https://open.cdash.org/viewBuildError.php?buildid=7515599 saying: > D:/a/1/s-build/Wrapping/ITKFactoryRegistration\itkImageIOFactoryRegisterManager.h:49:18: error: constexpr variable 'ImageIOFactoryRegisterRegisterList' must be initialized by a constant expression These errors occurred after pull request #2811 "Fix various Clang-Tidy warnings from the three itk*IOFactoryRegisterManager.h.in files" commit f56cc7e "COMP: Add "const" to `IOFactoryRegisterManager` implementations"
InsightSoftwareConsortium · Oct 19, 2021 · 3ad34a1 · 3ad34a1
1 parent 962b55f
commit 3ad34a1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CMake/itkImageIOFactoryRegisterManager.h.in b/CMake/itkImageIOFactoryRegisterManager.h.in
@@ -46,7 +46,7 @@ class ImageIOFactoryRegisterManager
 // ITK-based applications and not in ITK itself.
 //
 
-constexpr void (*ImageIOFactoryRegisterRegisterList[])(void) = {
+void (* const ImageIOFactoryRegisterRegisterList[])(void) = {
   @LIST_OF_FACTORY_NAMES@
   nullptr};
 const ImageIOFactoryRegisterManager ImageIOFactoryRegisterManagerInstance(ImageIOFactoryRegisterRegisterList);

diff --git a/CMake/itkMeshIOFactoryRegisterManager.h.in b/CMake/itkMeshIOFactoryRegisterManager.h.in
@@ -46,7 +46,7 @@ class MeshIOFactoryRegisterManager
 // ITK-based applications and not in ITK itself.
 //
 
-constexpr void (*MeshIOFactoryRegisterRegisterList[])(void) = {
+void (* const MeshIOFactoryRegisterRegisterList[])(void) = {
   @LIST_OF_FACTORY_NAMES@
   nullptr};
 const MeshIOFactoryRegisterManager MeshIOFactoryRegisterManagerInstance(MeshIOFactoryRegisterRegisterList);

diff --git a/CMake/itkTransformIOFactoryRegisterManager.h.in b/CMake/itkTransformIOFactoryRegisterManager.h.in
@@ -46,7 +46,7 @@ class TransformIOFactoryRegisterManager
 // ITK-based applications and not in ITK itself.
 //
 
-constexpr void (*TransformIOFactoryRegisterRegisterList[])(void) = {
+void (* const TransformIOFactoryRegisterRegisterList[])(void) = {
   @LIST_OF_FACTORY_NAMES@
   nullptr};
 const TransformIOFactoryRegisterManager TransformIOFactoryRegisterManagerInstance(TransformIOFactoryRegisterRegisterList);