BUG: add support for long long pixel types in PyBuffer #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:Bug
thewtex
approved these changes
May 28, 2021
Leengit
approved these changes
May 28, 2021
There was a problem hiding this comment.
This looks good to me.
Bigger picture than this PR is that on most (or all?) of our systems, the types UI, UL, and ULL collectively represent just the two uint32_t and uint64_t, so we are wrapping 2 sizes for the price of 3. Ideally, we would somehow map UL to its equivalent type in those stituations where it is equal to UI or ULL -- instead of wrapping UL separately. (Likewise for signed ints.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of #2554 for release branch.