STYLE: itkTimeVaryingBSplineVelocityFieldImageRegistrationMethod.hxx

[josempozo]

Removed useless operation: The body of the if condition only generated in-scope local objects which get removed when out of scope.

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

[dzenanz]

The body of the if condition has a side-effect: indirectly updating movingDisplacementFieldTransform. I don't know how important that is.

[josempozo]

The body of the if condition has a side-effect: indirectly updating movingDisplacementFieldTransform. I don't know how important that is.

The only call is movingDisplacementFieldTransform->GetDisplacementField().
This is a const function defined by itkGetConstObjectMacro. For what I understand, it only returns the pointer const to the displacementField (an itk::Image). Can there be any side effect triggered by that?

[dzenanz]

That by itself will not do much, but fieldDuplicatorIdentity->Update() will propagate the update to all its inputs. That probably includes movingDisplacementFieldTransform. These are comments from looking at the code, not from trying anything. The CI seems to be succeeding, so that side effect was probably not important.

[dzenanz]

You need to update the commit to add a STYLE: prefix. The PR title doesn't have to contain the prefix, as it can have multiple commits of different kinds.

[thewtex]

@ntustison any thoughts on functionality and purpose of the code proposed for removal?

[ntustison]

Hey @thewtex, sorry I missed this. Currently in London for the marathon but I'll take a look when I get back.

[thewtex]

@ntustison thanks! Have a great race!! 🏃‍♂️ 👟 🥇

[ntustison]

Sorry for the delay. Yeah, I don't know the reason for the code in question. All I can think of is that it was not removed when I integrated the point-set functionality. Thanks for looking at this.