ENH: Allow user-defined slicing over time or channel axes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Adds axes metadata parsing and exposes result in API - Exposes optional parameter to allow slicing over channel or time axes Addresses issue where 5D t/c/z/y/x volume subregions could not be read with OMEZarrNGFFImageIO because Tensorstore was not provided with enough information to map from 5D axes to 3D output image. Could be extended in the future to allow the user to override the default mapping of ITK dimension 0 -> "x", 1 -> "y", 2 -> "z" for different input axes.
dzenanz
reviewed
Aug 9, 2023
dzenanz
approved these changes
Aug 9, 2023
tbirdso
merged commit 08d3617
into
InsightSoftwareConsortium:master
14 of 17 checks passed
|
If there are no objections, I will tag a PyPI release to include this change. |
|
No objections from me. |
|
I neglected to update the module version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Addresses issue where 5D t/c/z/y/x volume subregions could not be read with OMEZarrNGFFImageIO because Tensorstore was not provided with enough information to map from 5D axes to 3D output image.
Could be extended in the future to allow the user to override the default mapping of ITK dimension 0 -> "x", 1 -> "y", 2 -> "z" for different input axes. (#45)