Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump for ITK v5.4rc02 pre-release candidate #58

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Nov 7, 2023

Bump for ITK v5.4rc02 and release v0.2.1

Bump for ITK v5.4rc02 and release v0.2.1
@tbirdso tbirdso requested a review from dzenanz November 7, 2023 13:59
@thewtex
Copy link
Member

thewtex commented Nov 7, 2023

git checkout v5.4rc02

error: Your local changes to the following files would be overwritten by checkout:
126
scripts/windows-build-tarball.ps1

This could be fixed with git checkout --ours v5.4rc02, but why are we not using the remote module GitHub Action?

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 7, 2023

why are we not using the remote module GitHub Action?

Tensorstore requires NASM and Perl which may require extra runner setup steps and thus don't seem to be compatible with our reusable workflow. Would be good to investigate further how we can support complex build prerequisites in the future.

Force ITKPythonPackage script checkout.

co-authored-by: Matt McCormick <[email protected]>
@thewtex thewtex merged commit 62482ac into InsightSoftwareConsortium:master Nov 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants