Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Require less components to be built for examples #213

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 25, 2023

No description provided.

Copy link

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzenanz Code looks good. Am I correct in understanding that ITKTestKernel is the only component that is no longer required to build for running ITKMontage examples here? If so, could that detail please be added to the commit message?

@dzenanz
Copy link
Member Author

dzenanz commented Jan 25, 2023

ITKTestKernel brings in a lot of IOs. If you think it is worthwhile, I could still update the commit message.

@tbirdso
Copy link

tbirdso commented Jan 25, 2023

Updating the commit message would help if someone has to look back through history, thanks. If tests are passing then it could be updated and merged without waiting for tests to re-run.

While this directly removes ITKTestKernel as a dependency,
it indirectly removes a lot of IO modules which ITKTestKernel requires.
@dzenanz dzenanz merged commit 76b2286 into InsightSoftwareConsortium:master Jan 25, 2023
@dzenanz
Copy link
Member Author

dzenanz commented Jan 25, 2023

Tests were passing, though I am not sure how sensitive they are to this change. I updated the commit message and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants