Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell watcher docstrings #716

Merged

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Dec 19, 2023

No description provided.

@bnmajor bnmajor requested a review from thewtex December 19, 2023 13:58
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome!

One minor request inline.

def not_named(self):
# Return a list of names of viewers that have not been named yet
return any([k for k, v in self.data.items() if v['name'] is None])
:return: The data object that contains all created Viewer information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we describe here what the str, str, bool's are?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thewtex thewtex merged commit 9ad4d2c into InsightSoftwareConsortium:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants