Select roi rechunk filter itkwasm #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the roi image, when used later either in another view call or saving with to_ngff_zarr, we do not run into the error: ``` ValueError: Attempt to save array to zarr with irregular chunking, please call `arr.rechunk(...)` first ```
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bnmajor
approved these changes
Dec 19, 2023
| @@ -429,6 +429,7 @@ async def get_roi_image(self, scale: int = -1, name: str = 'Image') -> NgffImage | |||
| multiscales = from_ngff_zarr(store) | |||
| loaded_image = multiscales.images[scale] | |||
| roi_data = loaded_image.data[roi_slices] | |||
| roi_data = roi_data.rechunk(loaded_image.data.chunksize) | |||
There was a problem hiding this comment.
Ah, I did not encounter this error in my testing - I'm glad you caught this!
There was a problem hiding this comment.
Yes, it seemed to happen occasionally, especially with thin slabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.