Update TensorStore #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbirdso
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Nice! Rebase looks good, two questions/requests:
- Can we confirm that zip functionality is still working after the rebase? Covered under unit testing?
- Do we have a way to revert if something has gone wrong in the rebase? Maybe a copy of the old
masterbranch is or could be maintained?
|
|
I created branches here, called |
|
I now realize that previous link is not the best check of release1 working, but InsightSoftwareConsortium/ITKIOOMEZarrNGFF#54. This run and corresponding dashboard build just tell us that the bug fix did not introduce any new problems for the old code. |
|
We should probably have a tagged and released package with the old version before we pull the trigger on this. To be done after InsightSoftwareConsortium/ITKIOOMEZarrNGFF#44. |
dzenanz
force-pushed
the
master
branch
2 times, most recently
from
e3e544a
to
9d45c2f
Compare
dzenanz
merged commit 9d45c2f
into
InsightSoftwareConsortium:master
3 of 8 checks passed
|
Skipping this intermediate version. I repointed master to 9d45c2f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update is accomplished by rebasing and adding a minor compile fix.