Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base deployment #75

Closed
wants to merge 2 commits into from
Closed

Base deployment #75

wants to merge 2 commits into from

Conversation

thrilok209
Copy link
Member

Deployment of DSA contracts on base chain

adarshswaminath
adarshswaminath reviewed Nov 30, 2023
View reviewed changes
Copy link

@adarshswaminath adarshswaminath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review for deployAll.ts

  • The script maintains a consistent structure, which is good for readability and maintainability.
  • The task name "verify:verify" is used consistently. Consider adding a comment explaining its specific purpose.

@Shai69bb
Copy link

verify : verify is the task name that was added to deployAll.ts. This script is important because the structure is consistently maintained and allows for good readability.

@thrilok209 thrilok209 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarshswaminath adarshswaminath adarshswaminath left review comments

@ishanjain28 ishanjain28 ishanjain28 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thrilok209 @Shai69bb @ishanjain28 @adarshswaminath